Add missing distortion keyword to ref_file
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
requested review from
kdupriestsci,
jbrookens and
a team
as code owners
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 4 4
Lines 124 124
=======================================
Hits 116 116
Misses 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
bugfix/distortion_keyword
branch
from
8e21538 to
b873c86
Compare
|
Passed regression tests, see: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/134/ |
ddavis-stsci
approved these changes
Apr 19, 2023
WilliamJamieson
force-pushed
the
bugfix/distortion_keyword
branch
from
b873c86 to
637500d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reopen of #234 due to some GitHub weirdness about branch changes not appearing in PRs. This solves the
distortionissue mentioned in spacetelescope/roman_datamodels#151.Checklist
CHANGES.rstunder the corresponding subsection